Review Request 123999: Don't crash in XRandrBrightness if not on xcb

Martin Gräßlin mgraesslin at kde.org
Thu Jun 4 14:09:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123999/
-----------------------------------------------------------

(Updated June 4, 2015, 2:09 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Solid and Kai Uwe Broulik.


Changes
-------

Submitted with commit bb67165aa5d99e9eeea3c7f8b328b3b53a5e70a5 by Martin Gräßlin to branch master.


Repository: powerdevil


Description
-------

On e.g. platform wayland XRandrBrightness shouldn't do anything. By
skipping the initialization the isSupported returns false.


Diffs
-----

  daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850 

Diff: https://git.reviewboard.kde.org/r/123999/diff/


Testing
-------

kded5 no longer crashes when initializing powerdevil when running with platform wayland.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/64bcb44a/attachment.html>


More information about the Plasma-devel mailing list