Review Request 123999: Don't crash in XRandrBrightness if not on xcb

Kai Uwe Broulik kde at privat.broulik.de
Thu Jun 4 10:04:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123999/#review81165
-----------------------------------------------------------

Ship it!


Ship It!

- Kai Uwe Broulik


On Juni 3, 2015, 11:08 nachm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123999/
> -----------------------------------------------------------
> 
> (Updated Juni 3, 2015, 11:08 nachm.)
> 
> 
> Review request for Plasma, Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> On e.g. platform wayland XRandrBrightness shouldn't do anything. By
> skipping the initialization the isSupported returns false.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850 
> 
> Diff: https://git.reviewboard.kde.org/r/123999/diff/
> 
> 
> Testing
> -------
> 
> kded5 no longer crashes when initializing powerdevil when running with platform wayland.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150604/4f17552d/attachment.html>


More information about the Plasma-devel mailing list