Review Request 123991: Select lockscreenpassword not until user can type

[Martin Klapetek]

> On June 3, 2015, 5:58 p.m., Martin Klapetek wrote:
> > Can you please explain once again what the problem is and why this solves it?
> 
> David Kahles wrote:
>     I forgot to mention that this refers to the lockscreen, sorry.
>     
>     If the user types in the wrong password, a timer runs 3 second long, and after this period the user is able to type in a new password. The wrong password gets selected as soon as the user presses the login button, but he can't type in a new password until the timer expired. This is bad, because the user thinks he can type in the new password as soon as the old one is selected.
>     With this patch, the wrong password gets selected just when the timer expires and when the user is able to type in another password.

Thanks for that; isn't this related rather to the Timer around line 160? That one sets the focus after 200ms. Maybe the call should be moved into the grace timer timeout slot?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123991/#review81129
-----------------------------------------------------------


On June 3, 2015, 7:26 p.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123991/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 7:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This selects the (wrong) password at the lockscreen not before the grace lock timer is expired, because the user can't type before.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml d5cd081830518ec4d75e675281a5a0bd1cbb59b6 
> 
> Diff: https://git.reviewboard.kde.org/r/123991/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me, tested on two archlinux machines.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150603/94f33d24/attachment.html>