Review Request 124555: use kwayland to move Plasma::Dialog

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124555/#review83262
-----------------------------------------------------------


The copy of dialog.h somehow scares me - is there no other way? I'm afraid it will totally get out of sync especially given that the release cycles are not synced.


shell/shellcorona.cpp (line 213)
<https://git.reviewboard.kde.org/r/124555/#comment57493>

    instead of casting twice (see line 217) store the pointer to Dialog in a temp variable?


- Martin Gräßlin


On Juli 31, 2015, 5:23 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124555/
> -----------------------------------------------------------
> 
> (Updated Juli 31, 2015, 5:23 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> since we can't subclass Dialog (created from QML) inject a class that will control it with event filters from the shell (in an eventfilter as well installed on the qapp)
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 3cfc84b 
>   shell/plasmaquick/dialog.h PRE-CREATION 
>   shell/shellcorona.h 9e93844 
>   shell/shellcorona.cpp fbffbb0 
>   shell/waylanddialogfilter.h PRE-CREATION 
>   shell/waylanddialogfilter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150731/afd3e818/attachment.html>