Review Request 124555: use kwayland to move Plasma::Dialog

Mark Gaiser markg85 at gmail.com
Fri Jul 31 17:21:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124555/#review83250
-----------------------------------------------------------



shell/waylanddialogfilter.cpp (line 26)
<https://git.reviewboard.kde.org/r/124555/#comment57485>

    This one seems to be unused.


- Mark Gaiser


On jul 31, 2015, 3:23 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124555/
> -----------------------------------------------------------
> 
> (Updated jul 31, 2015, 3:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> since we can't subclass Dialog (created from QML) inject a class that will control it with event filters from the shell (in an eventfilter as well installed on the qapp)
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt 3cfc84b 
>   shell/plasmaquick/dialog.h PRE-CREATION 
>   shell/shellcorona.h 9e93844 
>   shell/shellcorona.cpp fbffbb0 
>   shell/waylanddialogfilter.h PRE-CREATION 
>   shell/waylanddialogfilter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150731/16758dfc/attachment.html>


More information about the Plasma-devel mailing list