Review Request 124469: ConsoleKit2 support for screenlocker

[Eric Koegel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124469/
-----------------------------------------------------------

(Updated July 29, 2015, 4:10 p.m.)


Review request for Plasma.


Changes
-------

Thanks for the reviews!

Removed the service watcher for CK. Also have it give preference to logind.
Changed the case of the variables to match the standard and set the pointers to nullptr initially.
Added a check in inhibit to see if we're connected to a service.


Repository: plasma-workspace


Description
-------

ConsoleKit2 has the same API as systemd-logind for Lock, Unlock,
PrepareForSleep, and Inhibit. This patch adds the functionality
for ConsoleKit2 while attempting to minimize code duplication.


Diffs (updated)
-----

  ksmserver/screenlocker/logind.h 9983673 
  ksmserver/screenlocker/logind.cpp 5335b15 

Diff: https://git.reviewboard.kde.org/r/124469/diff/


Testing
-------

dbus-send --system --dest=org.freedesktop.ConsoleKit   --type=method_call --print-reply --reply-timeout=2000   /org/freedesktop/ConsoleKit/Manager   org.freedesktop.ConsoleKit.Manager.ListInhibitors
method return sender=:1.1 -> dest=:1.80 reply_serial=2
   array [
      struct {
         string "suspend"
         string "NetworkManager"
         string "NetworkManager needs to turn off networks"
         string "delay"
         uint32 0
         uint32 3473
      }
      struct {
         string "handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch"
         string "PowerDevil"
         string "KDE handles power events"
         string "block"
         uint32 1000
         uint32 9587
      }
      struct {
         string "suspend"
         string "Screen Locker"
         string "Ensuring that the screen gets locked before going to sleep"
         string "delay"
         uint32 1000
         uint32 9508
      }
   ]

Verified ConsoleKit2 does delay suspending until both delay locks are removed.


Thanks,

Eric Koegel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150729/62835cda/attachment.html>