Review Request 123889: [krunner] Add button to clear history

Wed Jul 29 08:59:18 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123889/
-----------------------------------------------------------

(Updated July 29, 2015, 8:59 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, KDE Usability and Vishesh Handa.

Changes
-------

Submitted with commit 703e9b113c07c447d7d4e3d65c7216627af4865a by Kai Uwe Broulik to branch master.

Bugs: 275645?
    https://bugs.kde.org/show_bug.cgi?id=275645?

Repository: plasma-desktop

Description
-------

This adds a "Clear history" button to the plasmasearch kcm to clear the history.

Diffs
-----

  kcms/runners/kcm.cpp 10b7683 

Diff: https://git.reviewboard.kde.org/r/123889/diff/

Testing
-------

Clicked button, history gone, popup updated automatically. Could perhaps check whether the history is currently empty and be disabled in that case? Dunno if adding a file watcher to track live changes is worth it though.

File Attachments
----------------

Button in KCM
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/c86950ed-04ca-4d3d-8697-a13c21b47ad6__krunnerclearhistory.png

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150729/c544ca16/attachment-0001.html>