Review Request 124499: Detect initial face icon being created

[Sebastian Kügler]

> On July 27, 2015, 9:38 p.m., Aleix Pol Gonzalez wrote:
> > src/qmlcontrols/kcoreaddons/kuserproxy.cpp, line 47
> > <https://git.reviewboard.kde.org/r/124499/diff/1/?file=388164#file388164line47>
> >
> >     Is the watch always needed or only if it's empty?
> >     
> >     This wasn't added before...

I think it's useful also for when the user changes the face icon. Otherwise we only update it on login (or after plasmashell restarts during a crash ;)).


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124499/#review83065
-----------------------------------------------------------


On July 27, 2015, 9:32 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124499/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 9:32 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Detect initial face icon being created.
> 
> I think it's a bit messy, but can't come up with anything else. 
> Potentially will be replaced by AccountsService soon anyway...
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kcoreaddons/kuserproxy.cpp 383220fc901010cc2b7d9a5b7f7fc3928835b445 
> 
> Diff: https://git.reviewboard.kde.org/r/124499/diff/
> 
> 
> Testing
> -------
> 
> Literally none.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150728/ce87cf0e/attachment.html>