Review Request 124499: Detect initial face icon being created

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 27 21:38:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124499/#review83065
-----------------------------------------------------------



src/qmlcontrols/kcoreaddons/kuserproxy.cpp (line 47)
<https://git.reviewboard.kde.org/r/124499/#comment57350>

    Is the watch always needed or only if it's empty?
    
    This wasn't added before...


- Aleix Pol Gonzalez


On July 27, 2015, 11:32 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124499/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 11:32 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Detect initial face icon being created.
> 
> I think it's a bit messy, but can't come up with anything else. 
> Potentially will be replaced by AccountsService soon anyway...
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kcoreaddons/kuserproxy.cpp 383220fc901010cc2b7d9a5b7f7fc3928835b445 
> 
> Diff: https://git.reviewboard.kde.org/r/124499/diff/
> 
> 
> Testing
> -------
> 
> Literally none.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150727/5ca26e55/attachment.html>


More information about the Plasma-devel mailing list