Review Request 124310: Improve quick chat widget

[Aleix Pol Gonzalez]

> On July 9, 2015, 8:14 p.m., Aleix Pol Gonzalez wrote:
> > chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml, line 153
> > <https://git.reviewboard.kde.org/r/124310/diff/1/?file=383909#file383909line153>
> >
> >     don't remove followConversation, we need it to go false only when the user moves the flickable. Sending a message or receiving an image can do that as well.
> 
> Kai Uwe Broulik wrote:
>     Hm, indeed. However, neither with, nor without it works properly.

For me, as is at the moment, without a scrollbar, it works fine.

Problem is that on resize (e.g. message received), the scrollbar moves the handle, then the handle moves the flickable.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124310/#review82287
-----------------------------------------------------------


On July 9, 2015, 8:03 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124310/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 8:03 p.m.)
> 
> 
> Review request for Plasma and Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> This improves the chat widget by:
> - Not hardcoding the hader size
> - Using a heading for the name so it stands out a bit more (since it's often not obvious at a glance who you're writing to)
> - Giving it a proper scroll bar
> - Making the auto scrolling a bit more robust
> - Cleaing up the code a bit
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 4e802c7 
> 
> Diff: https://git.reviewboard.kde.org/r/124310/diff/
> 
> 
> Testing
> -------
> 
> Been using it for a while, works nicely and looks better
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150709/22357966/attachment.html>