Review Request 124310: Improve quick chat widget

[Kai Uwe Broulik]

> On Juli 9, 2015, 6:14 nachm., Aleix Pol Gonzalez wrote:
> > chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml, line 92
> > <https://git.reviewboard.kde.org/r/124310/diff/1/?file=383909#file383909line92>
> >
> >     I would rather not. We used to have this scrollbar. It doesn't add anything to the plate, it takes space and it did't work all that well.

It's not just that but ScrollArea also does away with the abysmal scroll behavior of Flickable/ListView


> On Juli 9, 2015, 6:14 nachm., Aleix Pol Gonzalez wrote:
> > chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml, line 153
> > <https://git.reviewboard.kde.org/r/124310/diff/1/?file=383909#file383909line153>
> >
> >     don't remove followConversation, we need it to go false only when the user moves the flickable. Sending a message or receiving an image can do that as well.

Hm, indeed. However, neither with, nor without it works properly.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124310/#review82287
-----------------------------------------------------------


On Juli 9, 2015, 6:03 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124310/
> -----------------------------------------------------------
> 
> (Updated Juli 9, 2015, 6:03 nachm.)
> 
> 
> Review request for Plasma and Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> This improves the chat widget by:
> - Not hardcoding the hader size
> - Using a heading for the name so it stands out a bit more (since it's often not obvious at a glance who you're writing to)
> - Giving it a proper scroll bar
> - Making the auto scrolling a bit more robust
> - Cleaing up the code a bit
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 4e802c7 
> 
> Diff: https://git.reviewboard.kde.org/r/124310/diff/
> 
> 
> Testing
> -------
> 
> Been using it for a while, works nicely and looks better
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150709/ad1ce1a4/attachment-0001.html>