Review Request 124298: Remove logitech-mouse-related code

Hrvoje Senjan hrvoje.senjan at gmail.com
Wed Jul 8 17:16:50 UTC 2015



> On July 8, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> > kcms/input/CMakeLists.txt, line 43
> > <https://git.reviewboard.kde.org/r/124298/diff/1/?file=383779#file383779line43>
> >
> >     You probably also want to delete the logitechmouse_base.ui file

Yeah, deleted that one and header locally, but this isn't shown with git diff...


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124298/#review82235
-----------------------------------------------------------


On July 8, 2015, 7:05 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124298/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 7:05 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> As was agreed in review 124275.
> Newest device the code supports is from 2004.
> Code uses deprecated libusb library.
> It's questionable whether out-of-the-box support is working.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ff413a1 
>   kcms/input/CMakeLists.txt 67f664d 
>   kcms/input/logitechmouse.cpp 49364ea 
>   kcms/input/mouse.h 177fcda 
>   kcms/input/mouse.cpp 195f29f 
> 
> Diff: https://git.reviewboard.kde.org/r/124298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150708/9ce90aad/attachment.html>


More information about the Plasma-devel mailing list