Review Request 124298: Remove logitech-mouse-related code

Kai Uwe Broulik kde at privat.broulik.de
Wed Jul 8 17:09:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124298/#review82235
-----------------------------------------------------------


+1


kcms/input/CMakeLists.txt (line 33)
<https://git.reviewboard.kde.org/r/124298/#comment56611>

    You probably also want to delete the logitechmouse_base.ui file


- Kai Uwe Broulik


On Juli 8, 2015, 5:05 nachm., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124298/
> -----------------------------------------------------------
> 
> (Updated Juli 8, 2015, 5:05 nachm.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> As was agreed in review 124275.
> Newest device the code supports is from 2004.
> Code uses deprecated libusb library.
> It's questionable whether out-of-the-box support is working.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ff413a1 
>   kcms/input/CMakeLists.txt 67f664d 
>   kcms/input/logitechmouse.cpp 49364ea 
>   kcms/input/mouse.h 177fcda 
>   kcms/input/mouse.cpp 195f29f 
> 
> Diff: https://git.reviewboard.kde.org/r/124298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150708/5faf7485/attachment.html>


More information about the Plasma-devel mailing list