Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path

Martin Gräßlin mgraesslin at kde.org
Tue Jul 7 11:42:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124268/
-----------------------------------------------------------

(Updated July 7, 2015, 11:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit e63fb9914a5395a1e3c7125d303b4a0b4935a9ad by Martin Gräßlin to branch master.


Repository: plasma-desktop


Description
-------

Compatibility code for old Qt releases. Neither Qt 4 nor Qt 5 use this
property [1].

Whether this code would still work for Qt 2 or 3 at all is certainly
unknown, but it clearly crashes with QT_QPA_PLATFORM=wayland.

[1] checked with git grep in qt4 and qt5/qtbase


Diffs
-----

  kcms/style/kcmstyle.cpp fb543972c7cc0c9c7dc8753f8917781a4de00637 

Diff: https://git.reviewboard.kde.org/r/124268/diff/


Testing
-------

no longer crashes on Wayland


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/debc43b3/attachment.html>


More information about the Plasma-devel mailing list