Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124268/#review82118
-----------------------------------------------------------


+1

- Aleix Pol Gonzalez


On July 6, 2015, 1:46 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124268/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 1:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Compatibility code for old Qt releases. Neither Qt 4 nor Qt 5 use this
> property [1].
> 
> Whether this code would still work for Qt 2 or 3 at all is certainly
> unknown, but it clearly crashes with QT_QPA_PLATFORM=wayland.
> 
> [1] checked with git grep in qt4 and qt5/qtbase
> 
> 
> Diffs
> -----
> 
>   kcms/style/kcmstyle.cpp fb543972c7cc0c9c7dc8753f8917781a4de00637 
> 
> Diff: https://git.reviewboard.kde.org/r/124268/diff/
> 
> 
> Testing
> -------
> 
> no longer crashes on Wayland
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150706/06b417cc/attachment.html>