Review Request 124246: Improve sticky notes

Tue Jul 7 00:54:33 UTC 2015

> On July 4, 2015, 9:01 p.m., Heiko Tietze wrote:
> > Didn't test the workflow so just about the screenshot. Alignment looks somewhat strange. According https://techbase.kde.org/Projects/Usability/HIG/Alignment the right position is left for the longest label and all other to its right edge. Furthermore the checkbox as introduction to the function is weird. If non-custom means black you could simply omit the checkbox. Probably you adjust b/w in respect to the background. Hence the color would rather fit an indented child below the checkbox. I wonder why font size and color can be set but no other option. Either it's too much (who needs to set color to green or change the default font) or not enough (why not have comic font).
> 
> Kai Uwe Broulik wrote:
>     Formatting options like bold, italic, and the like are set in the applet using the formatting buttons similar to a word processor and not globally. Font size is a must (I often use huge sticky notes as really important reminders), not sure about font color (given you can already achieve emphasis by changing the note color) and font family.
> 
> Thomas Pfeiffer wrote:
>     I do agree with Heiko that being able to set font color and size, but not font family,  is really odd.
>     Font style (bold etc.) should indeed not be set globally because they are used for emphasis. Font family, on the other hand, are as much of a stylistic preference as color and size.
>     
>     As for the "I want huge notes for important stuff": Why not adjusting the size automatically so that the text always fills the whole widget?
>     That way you could use huge _notes_ (as opposed to normal-sized notes with huge text) for important stuff. Of course the font size should never shrink below minimum readable size.
>     
>     As for the font color: I'd rather vote for adjusting it automatically with the note color (possibly allowing e.g. "Black on yellow" and "Red on yellow" as separate options if we think both make sense). That would also ensure could contrast.
>     
>     So, long story short: I am against offering any font settings for the Plasmoid as such.
> 
> Kai Uwe Broulik wrote:
>     > Why not adjusting the size automatically so that the text always fills the whole widget?
>     
>     Because I might place a lot of stuff into a note or just little. I want to have the control over the sizing to not have it look odd when I have 10 sticky notes, all with different size. I do make them huge if I want huge size but I wouldn't want an auto size.
>     > As for the font color: I'd rather vote for adjusting it automatically with the note color
>     
>     The font is black (well, very dark gray) by default and white for the black sticky note. 
>     > possibly allowing e.g. "Black on yellow" and "Red on yellow" as separate options
>     
>     ?

> Because I might place a lot of stuff into a note or just little. I want to have the control over the sizing to not have it look odd when I have 10 sticky notes, all with different size. I do make them huge if I want huge size but I wouldn't want an auto size.

Having font style (bold etc.) in the editor, size and color in the config and font family nowhere is still very inconsistent and confusing. Why not just putting text size, color and font family all in the editor, then? That way you can also use different sizes within the same note.

>> possibly allowing e.g. "Black on yellow" and "Red on yellow" as separate options

> ?

What I meant was that you'd not just set the background color to e.g. yellow and then the text color would automatically adjust, but if we assumed some people liked black text on yellow background and others liked red text on yellow background, we could offer both combinations in the color selection.

If we allow setting the text color manually in the editor, though, this would not be necessary anymore.

Bottom line: We need something more consistent than what you had in mind.

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124246/#review82080
-----------------------------------------------------------

On July 4, 2015, 11:43 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124246/
> -----------------------------------------------------------
> 
> (Updated July 4, 2015, 11:43 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> This patch adds the following improvements to the sticky notes applet:
> 
> - A config dialog with previews of the individual colors, the ability to change the font size, and font color - are there any other important options the 4.x one had?
> 
> - Ctrl+Mousewheel to change font size, I always used this "feature" in 4.x and was disappointed that it would not actually save the font size
> 
> - Focus the input field when expanding the applet (eg. when it is in a panel, click the note, start typing)
> 
> - Drag and drop support so you can now drag files and text snippets into the sticky note
> 
> - Better keyboard navigation: you can now place a sticky note in your panel, assign a shortcut to it, press it, note down your thoughts, and close the note again
> 
> 
> Diffs
> -----
> 
>   applets/notes/package/contents/config/config.qml PRE-CREATION 
>   applets/notes/package/contents/config/main.xml 596dfc0 
>   applets/notes/package/contents/ui/configAppearance.qml PRE-CREATION 
>   applets/notes/package/contents/ui/main.qml 1f1022c 
>   applets/notes/plugin/documenthandler.h 41cf704 
>   applets/notes/plugin/documenthandler.cpp 79c276e 
> 
> Diff: https://git.reviewboard.kde.org/r/124246/diff/
> 
> 
> Testing
> -------
> 
> Changing the font size from the config dialog and mousewheeling seems to work without screwing up your existing formatting.
> 
> Unfortunately the config dialog is quite difficult to get to since right clicking the text area yields the standard copy/paste menu and I failed to manually add another item for the applet config there
> 
> 
> File Attachments
> ----------------
> 
> Config dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/04/1d244f32-79e6-435c-a906-1acddede0aa3__stickylove3.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150707/4b142ac6/attachment.html>