Review Request 124260: Also check for SharedEngineView

Kai Uwe Broulik kde at privat.broulik.de
Sun Jul 5 13:24:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124260/
-----------------------------------------------------------

(Updated July 5, 2015, 1:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 5cf9c04ff5a6809bf67fa27c86f5393d1ba9d08b by Kai Uwe Broulik to branch master.


Bugs: 349172
    http://bugs.kde.org/show_bug.cgi?id=349172


Repository: plasma-framework


Description
-------

This fixes dialogs like Kickoff not closing when the desktop is clicked.

Interestingly enough the condition focusWindow->type() & Qt::Popup evaluates true for the DesktopView.


Diffs
-----

  src/plasmaquick/dialog.cpp 2166880 

Diff: https://git.reviewboard.kde.org/r/124260/diff/


Testing
-------

Opened kickoff, clicked desktop, kickoff closed


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150705/6557ecfa/attachment.html>


More information about the Plasma-devel mailing list