Review Request 124260: Also check for SharedEngineView

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124260/#review82095
-----------------------------------------------------------

Ship it!


Ship It!

- Eike Hein


On July 5, 2015, 1:05 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124260/
> -----------------------------------------------------------
> 
> (Updated July 5, 2015, 1:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 349172
>     http://bugs.kde.org/show_bug.cgi?id=349172
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This fixes dialogs like Kickoff not closing when the desktop is clicked.
> 
> Interestingly enough the condition focusWindow->type() & Qt::Popup evaluates true for the DesktopView.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 2166880 
> 
> Diff: https://git.reviewboard.kde.org/r/124260/diff/
> 
> 
> Testing
> -------
> 
> Opened kickoff, clicked desktop, kickoff closed
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150705/c5544eaf/attachment-0001.html>