Review Request 122328: Fix apply button in breeze window decoration config

Hugo Pereira Da Costa hugo.pereira at free.fr
Fri Jan 30 13:02:18 UTC 2015


On 01/30/2015 01:57 PM, Pinak Ahuja wrote:
>
> Commit to master right?
>
Yes,
in fact, the code as changed quite some already between 5.2 and master, 
and it might well be that the origin of the problem is unrelated to the 
change your patch contains. Still, since it is a valid change, go ahead 
and push it.
I'll investigate the issue in Plasma/5.2 separately.

Best regards,

Hugo

> On 30 Jan 2015 17:38, "Hugo Pereira Da Costa" <hugo.pereira at free.fr 
> <mailto:hugo.pereira at free.fr>> wrote:
>
>     This is an automatically generated e-mail. To reply, visit:
>     https://git.reviewboard.kde.org/r/122328/
>
>
>         On January 30th, 2015, 12:01 p.m. UTC, *Hugo Pereira Da Costa*
>         wrote:
>
>             Ship It!
>
>     PS: do you have commit access ? Otherwise I can commit for you.
>
>
>     - Hugo
>
>
>     On January 30th, 2015, 11:42 a.m. UTC, Pinak Ahuja wrote:
>
>     Review request for Plasma and Hugo Pereira Da Costa.
>     By Pinak Ahuja.
>
>     /Updated Jan. 30, 2015, 11:42 a.m./
>
>     *Repository: * breeze
>
>
>       Description
>
>     The apply button in breeze's config in windows decoration kcm
>     wasn't becoming active on changing the config. This fixes its
>     behaviour.
>
>
>       Testing
>
>     Compiled and installed, apply button works as expected.
>
>
>       Diffs
>
>       * kdecoration/config/breezeconfigwidget.cpp (e160c57)
>
>     View Diff <https://git.reviewboard.kde.org/r/122328/diff/>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150130/8d3cd3da/attachment-0001.html>


More information about the Plasma-devel mailing list