<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 01/30/2015 01:57 PM, Pinak Ahuja
wrote:<br>
</div>
<blockquote
cite="mid:CAAbh0gBynuWG2V-D_c+w_5VkODHm9uCtJRwn7w-vtAnSp-ZCwg@mail.gmail.com"
type="cite">
<p dir="ltr">Commit to master right?</p>
</blockquote>
Yes, <br>
in fact, the code as changed quite some already between 5.2 and
master, and it might well be that the origin of the problem is
unrelated to the change your patch contains. Still, since it is a
valid change, go ahead and push it.<br>
I'll investigate the issue in Plasma/5.2 separately.<br>
<br>
Best regards,<br>
<br>
Hugo<br>
<br>
<blockquote
cite="mid:CAAbh0gBynuWG2V-D_c+w_5VkODHm9uCtJRwn7w-vtAnSp-ZCwg@mail.gmail.com"
type="cite">
<div class="gmail_quote">On 30 Jan 2015 17:38, "Hugo Pereira Da
Costa" <<a moz-do-not-send="true"
href="mailto:hugo.pereira@free.fr">hugo.pereira@free.fr</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px #c9c399 solid;border-radius:6px"
bgcolor="#f9f3c9" cellpadding="12" width="100%">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To
reply, visit: <a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/122328/"
target="_blank">https://git.reviewboard.kde.org/r/122328/</a>
</td>
</tr>
</tbody>
</table>
<br>
<blockquote style="margin-left:1em;border-left:2px solid
#d0d0d0;padding-left:10px">
<p style="margin-top:0">On January 30th, 2015, 12:01
p.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid
#d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Ship It!</p></pre>
</blockquote>
</blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">PS: do you have commit access ? Otherwise I can commit for you.</p></pre>
<br>
<p>- Hugo</p>
<br>
<p>On January 30th, 2015, 11:42 a.m. UTC, Pinak Ahuja
wrote:</p>
<table style="border:1px #888a85 solid;border-radius:6px"
bgcolor="#fefadf" cellpadding="12" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da
Costa.</div>
<div>By Pinak Ahuja.</div>
<p style="color:grey"><i>Updated Jan. 30, 2015,
11:42 a.m.</i></p>
<div style="margin-top:1.5em"> <b
style="color:#575012;font-size:10pt">Repository:
</b>
breeze
</div>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Description
</h1>
<table style="border:1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">The apply button in breeze's config in windows decoration kcm wasn't becoming active on changing the config. This fixes its behaviour.</p></pre>
</td>
</tr>
</tbody>
</table>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Testing
</h1>
<table style="border:1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Compiled and installed, apply button works as expected.</p></pre>
</td>
</tr>
</tbody>
</table>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs
</h1>
<ul style="margin-left:3em;padding-left:0">
<li>kdecoration/config/breezeconfigwidget.cpp <span
style="color:grey">(e160c57)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="https://git.reviewboard.kde.org/r/122328/diff/"
style="margin-left:3em" target="_blank">View
Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</div>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>