Review Request 122209: [plasma-workspace] Make tests optional

David Edmundson david at davidedmundson.co.uk
Wed Jan 28 14:35:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122209/#review74914
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Jan. 22, 2015, 9:43 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122209/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 9:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Qt5Test should not be mandatory. The patch moves find_package(Qt5Test...) out of CMakeLists.txt
> and adds drkonqi/internalkxmlrpcclient/autotests only if(BUILD_TESTING).
> 
> I do not have write access.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e4d2b2dcf25ce7892f63c0279cea99329ec4b5f4 
>   drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaaa0b058fa38d44dd52bd5b93f2b839d6f8 
> 
> Diff: https://git.reviewboard.kde.org/r/122209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150128/88f1f5c1/attachment.html>


More information about the Plasma-devel mailing list