Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly.
Dmitry Shachnev
mitya57 at gmail.com
Tue Jan 20 15:48:46 UTC 2015
> On Янв. 20, 2015, 3:46 п.п., Marco Martin wrote:
> > Ship It!
I will need someone to push it for me, but first I want to get the meteo-qt developer to test it (I have sent him a link), wait until that please.
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122171/#review74397
-----------------------------------------------------------
On Янв. 20, 2015, 3:40 п.п., Dmitry Shachnev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122171/
> -----------------------------------------------------------
>
> (Updated Янв. 20, 2015, 3:40 п.п.)
>
>
> Review request for Plasma.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> Implement SystemTrayMenuItem::setMenu() correctly.
>
> We need to actually set the action menu, not just store it somewhere, to make submenus in tray icons working.
>
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7
> src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f
>
> Diff: https://git.reviewboard.kde.org/r/122171/diff/
>
>
> Testing
> -------
>
> Tested this app: https://github.com/dglent/meteo-qt
>
>
> Thanks,
>
> Dmitry Shachnev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150120/cfbfacea/attachment.html>
More information about the Plasma-devel
mailing list