Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly.
Marco Martin
notmart at gmail.com
Tue Jan 20 15:46:21 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122171/#review74397
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Jan. 20, 2015, 3:40 p.m., Dmitry Shachnev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122171/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 3:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> Implement SystemTrayMenuItem::setMenu() correctly.
>
> We need to actually set the action menu, not just store it somewhere, to make submenus in tray icons working.
>
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7
> src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f
>
> Diff: https://git.reviewboard.kde.org/r/122171/diff/
>
>
> Testing
> -------
>
> Tested this app: https://github.com/dglent/meteo-qt
>
>
> Thanks,
>
> Dmitry Shachnev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150120/b3d6582b/attachment.html>
More information about the Plasma-devel
mailing list