Review Request 122133: Fix compilation error by using std::vector rather than a conventional array.

Roney Gomes roney477 at gmail.com
Sun Jan 18 22:41:02 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122133/
-----------------------------------------------------------

(Updated Jan. 18, 2015, 7:41 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
-------

I couldn't build plasma-desktop from master since the compiler was throwing the following error in keyboard/preview/kbpreviewframe.cpp, starting on line 184: "error: variable length array of non-POD element type 'QPoint'". 

The main source of the problem was the allocation of QPoint temp[cordi_count] bound to a non constant variable.

This patch makes use of some C++11 features, is that a problem?


Diffs
-----

  kcms/keyboard/preview/kbpreviewframe.cpp 9735eb0 

Diff: https://git.reviewboard.kde.org/r/122133/diff/


Testing
-------

plasma-desktop recompiled with success.


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150118/f403c32e/attachment-0001.html>


More information about the Plasma-devel mailing list