Review Request 122133: Fix compilation error by using std::vector rather than a conventional array.

Alex Richardson arichardson.kde at gmail.com
Sun Jan 18 21:57:41 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122133/#review74269
-----------------------------------------------------------


Fixed by https://git.reviewboard.kde.org/r/121762 which I just pushed

- Alex Richardson


On Jan. 18, 2015, 7:32 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122133/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2015, 7:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I couldn't build plasma-desktop from master since the compiler was throwing the following error in keyboard/preview/kbpreviewframe.cpp, starting on line 184: "error: variable length array of non-POD element type 'QPoint'". 
> 
> The main source of the problem was the allocation of QPoint temp[cordi_count] bound to a non constant variable.
> 
> This patch makes use of some C++11 features, is that a problem?
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/preview/kbpreviewframe.cpp 9735eb0 
> 
> Diff: https://git.reviewboard.kde.org/r/122133/diff/
> 
> 
> Testing
> -------
> 
> plasma-desktop recompiled with success.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150118/4e2bf4b2/attachment.html>


More information about the Plasma-devel mailing list