Review Request 122072: Bump SOVERSION in libksysguard due to BIC change in 3f9ecc33

[Eike Hein]

> On Jan. 15, 2015, 5:40 p.m., Gregor Mi wrote:
> > First of all, thanks Eike for the quick patch. I cannot comment much on the coding details of your change since this is new stuff for me. But my apologies for introducing this inconvenience. 
> > 
> > Though I am not the maintainer but the causer of the bug I'll gladly give a ShipIt. :)
> > 
> > A related thing is with https://git.reviewboard.kde.org/r/121831/: This also causes a BIC change and would therefore also require an SOVERSION bump. I am wondering if another SOVERSION change would be good regarding having stable KDE APIs. Is there a certain point in time when APIs like this one should not change anymore?

The underlying problem here is that the class isn't designed with a d-ptr which severely limits the changes you can make to it without breaking binary compatibility:

https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++

If we're going to break it further, it would probably make sense to redesign it to have d-ptr to future-proof it.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122072/#review74095
-----------------------------------------------------------


On Jan. 15, 2015, 1:24 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122072/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 1:24 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Martin Gräßlin, Gregor Mi, Marco Martin, and Harald Sitter.
> 
> 
> Bugs: 342837
>     https://bugs.kde.org/show_bug.cgi?id=342837
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> 3f9ecc33 in libksysguard.git added a new data member to the publically-exported Process class, which doesn't have a d-ptr. This is a BIC change, and currently causing lots of crashes for Plasma users (see bug 342837). This diff bumps the SO version for the processcore library - and for all the other libs installed by libksysguard, since I didn't want to bifurcate the version handling in the build system and make it much more complicated.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ca303e8045676b724d63d71a34345dbff92a6541 
>   ksgrd/CMakeLists.txt ed896a29a52855cf98f4e73833d7bbe76dde148a 
>   lsofui/CMakeLists.txt 5ae53b07f8b5d53c7246034e29910203f9a8a424 
>   processcore/CMakeLists.txt 13291056719878748df71e3e323e745397c3a54d 
>   processui/CMakeLists.txt f7b12d738410ce490e6cd3bd2c8ab6728a67f72c 
>   signalplotter/CMakeLists.txt 818c7d66871080c4bb0df3b337419f89a0813969 
> 
> Diff: https://git.reviewboard.kde.org/r/122072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150115/23e43d17/attachment.html>