<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122072/">https://git.reviewboard.kde.org/r/122072/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 15th, 2015, 5:40 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First of all, thanks Eike for the quick patch. I cannot comment much on the coding details of your change since this is new stuff for me. But my apologies for introducing this inconvenience. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Though I am not the maintainer but the causer of the bug I'll gladly give a ShipIt. :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A related thing is with https://git.reviewboard.kde.org/r/121831/: This also causes a BIC change and would therefore also require an SOVERSION bump. I am wondering if another SOVERSION change would be good regarding having stable KDE APIs. Is there a certain point in time when APIs like this one should not change anymore?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The underlying problem here is that the class isn't designed with a d-ptr which severely limits the changes you can make to it without breaking binary compatibility:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we're going to break it further, it would probably make sense to redesign it to have d-ptr to future-proof it.</p></pre>
<br />
<p>- Eike</p>
<br />
<p>On January 15th, 2015, 1:24 p.m. UTC, Eike Hein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Martin Gräßlin, Gregor Mi, Marco Martin, and Harald Sitter.</div>
<div>By Eike Hein.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2015, 1:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=342837">342837</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">3f9ecc33 in libksysguard.git added a new data member to the publically-exported Process class, which doesn't have a d-ptr. This is a BIC change, and currently causing lots of crashes for Plasma users (see bug 342837). This diff bumps the SO version for the processcore library - and for all the other libs installed by libksysguard, since I didn't want to bifurcate the version handling in the build system and make it much more complicated.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ca303e8045676b724d63d71a34345dbff92a6541)</span></li>
<li>ksgrd/CMakeLists.txt <span style="color: grey">(ed896a29a52855cf98f4e73833d7bbe76dde148a)</span></li>
<li>lsofui/CMakeLists.txt <span style="color: grey">(5ae53b07f8b5d53c7246034e29910203f9a8a424)</span></li>
<li>processcore/CMakeLists.txt <span style="color: grey">(13291056719878748df71e3e323e745397c3a54d)</span></li>
<li>processui/CMakeLists.txt <span style="color: grey">(f7b12d738410ce490e6cd3bd2c8ab6728a67f72c)</span></li>
<li>signalplotter/CMakeLists.txt <span style="color: grey">(818c7d66871080c4bb0df3b337419f89a0813969)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122072/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>