Review Request 122040: Improve KRunner behavior on adding/removing screens

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jan 13 15:29:50 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122040/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 3:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Vishesh Handa.


Bugs: 336616
    https://bugs.kde.org/show_bug.cgi?id=336616


Repository: plasma-workspace


Description
-------

Use Qt 5.4 API for screen removal which notifies us about the screen removed before having it removed.
Treat differently add and remove, current implementation wasn't very sensible.


Diffs
-----

  krunner/view.cpp 9d33fe5 

Diff: https://git.reviewboard.kde.org/r/122040/diff/


Testing
-------

Played around with it, no crashes.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150113/2c7cbdf3/attachment.html>


More information about the Plasma-devel mailing list