Review Request 122040: Improve KRunner behavior on adding/removing screens

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122040/#review73946
-----------------------------------------------------------

Ship it!


Good job! Gold star!

- Vishesh Handa


On Jan. 13, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122040/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 3:21 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Bugs: 336616
>     https://bugs.kde.org/show_bug.cgi?id=336616
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Use Qt 5.4 API for screen removal which notifies us about the screen removed before having it removed.
> Treat differently add and remove, current implementation wasn't very sensible.
> 
> 
> Diffs
> -----
> 
>   krunner/view.cpp 9d33fe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122040/diff/
> 
> 
> Testing
> -------
> 
> Played around with it, no crashes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150113/71743549/attachment.html>