Papercuts from review at sprint

[Martin Gräßlin]

On Thursday 26 February 2015 16:01:57 Sebastian Kügler wrote:
> On Thursday, February 26, 2015 08:30:46 Martin Gräßlin wrote:
> > On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote:
> > > On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote:
> > > > On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote:
> > > > 
> > > > 
> > > > The button is only shown if the window provides context help. So it is
> > > > already  quite conditionally. Where is that a problem?
> > > 
> > > We took the note when looking at systemsettings. The overview page gets
> > > the
> > > question mark in the toolbar, yet when I hover with the ? cursor,
> > > context
> > > help is nowhere to be found.
> > > 
> > > 
> > > 
> > > I guess that's one example, there may be others. It made us question the
> > > usefulness of that question mark button in the window decoration.
> > 
> > To explain how this works: the question mark is shown in the window
> > decoration  when the window signals that it supports the "provides context
> > help" mode. The window decoration cannot know whether there is something
> > actually providing it. So if it's wrongly shown this means fixing in the
> > application.
> > 
> > But the complete feature is questionably as it's a non-standard protocol
> > between Qt and KWin. To my knowledge no other window manager supports it
> > and  no other toolkit supports it. Which means that it's a dangerous
> > feature to put help into in a cross-desktop application.
> 
> So we'd have to gauge its usefulness overall, and see if it makes sense. Are
> there any apps which really use it, i.e. also provide whatsthis hints
> consistently?

There are many KCMs setting them. E.g. lots of KWin KCMs have such a hint 
(which might not be surprising as AFAIK the API was implemented by Matthias).

> 
> Otherwise, perhaps we should review those apps that request the "?", and in
> case it's nonsensical (such as in systemsettings), remove it.

In systemsettings it's only nonsensical for the kcms which do not have it. For 
the ones from KWin it makes sense.

> 
> Do you know how to find this "provides context help" API?

For example in ui files:
       <property name="whatsThis">
        <string>Here you can set that windows will be only snapped if you try 
to overlap them, i.e. they will not be snapped if the windows comes only near 
another window or border.</string>
       </property>

And QWidget::setWhatsThis

Cheers
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150226/40e88243/attachment.sig>