Review Request 121856: KWindowSystem import for KDeclarative

[Damian Ivanov]

Hi,

Why not include also setShowingDesktop function?

 void KWindowSystemProxy::setShowingDesktop(bool b)

{

        NETRootInfo rootInfo(QX11Info::connection(), NET::WMDesktop);

        rootInfo.setShowingDesktop(b);

}


PS:https://git.reviewboard.kde.org/r/121667/ fixed not only openbox,
but also gnome-shell/mutter. Thanks!


2015-02-20 18:25 GMT+02:00 Kai Uwe Broulik <kde at privat.broulik.de>:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121856/
>   This change has been marked as submitted.
>   Review request for kwin and Plasma.
> By Kai Uwe Broulik.
>
> *Updated Feb. 20, 2015, 4:25 p.m.*
>  *Repository: * kdeclarative
> Description
>
> This is a thin proxy around KWindowSystem exposing most of its methods to qml via KWindowSystem item in an org.kde.kwindowsystem import.
>
> It uses QWindow instead of WId parameters so you can just pass a qml Item, such as a Plasma Dialog as parameter for ease of use (and so you cannot mess with others windows without effort, also I don't know what "WId" would translate to anyway). It omits all those methods that return WId/QWindow as I don't know how expensive QWindow::fromWinId is or who takes ownership of it. We need to decide which methods make sense in this import.
>
> Methods that have signals and don't take parameters are turned into full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the rest stays Q_INVOKABLE.
>
>   Testing
>
> The properties work and change accordingly (compositing active signal doesn't seem to be emitted by KWindowSystem in the first place, at least Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works for Review 121807
>
>   Diffs
>
>    - src/qmlcontrols/CMakeLists.txt (39c39a5)
>    - src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt (PRE-CREATION)
>    - src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h
>    (PRE-CREATION)
>    - src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp
>    (PRE-CREATION)
>    - src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h
>    (PRE-CREATION)
>    - src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp
>    (PRE-CREATION)
>    - src/qmlcontrols/kwindowsystemplugin/qmldir (PRE-CREATION)
>
> View Diff <https://git.reviewboard.kde.org/r/121856/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150224/5f927279/attachment.html>