<div dir="ltr">Hi,<div><br><div>Why not include also setShowingDesktop function?</div></div><div>
<pre style="margin-top:0px;margin-bottom:0px"><span style="color:rgb(192,192,192)"> </span><span style="color:rgb(128,128,0)">void</span><span style="color:rgb(192,192,192)"> </span><span style="color:rgb(128,0,128)">KWindowSystemProxy</span><span style="color:rgb(0,0,0)">::</span><span style="color:rgb(0,0,0)">setShowingDesktop</span><span style="color:rgb(0,0,0)">(</span><span style="color:rgb(128,128,0)">bool</span><span style="color:rgb(192,192,192)"> </span><span style="color:rgb(0,0,0)">b</span><span style="color:rgb(0,0,0)">)</span></pre>
<pre style="margin-top:0px;margin-bottom:0px"><span style="color:rgb(0,0,0)">{</span></pre>
<pre style="margin-top:0px;margin-bottom:0px"><span style="font-family:arial,sans-serif;color:rgb(192,192,192)"> </span><span style="font-family:arial,sans-serif;color:rgb(128,0,128)">NETRootInfo</span><span style="font-family:arial,sans-serif;color:rgb(192,192,192)"> </span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">rootInfo</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">(</span><span style="font-family:arial,sans-serif;color:rgb(128,0,128)">QX11Info</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">::</span><span style="font-family:arial,sans-serif;color:rgb(128,0,0)">connection</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">(),</span><span style="font-family:arial,sans-serif;color:rgb(192,192,192)"> </span><span style="font-family:arial,sans-serif;color:rgb(128,0,128)">NET</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">::</span><span style="font-family:arial,sans-serif;color:rgb(128,0,128)">WMDesktop</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">);</span><br></pre>
<pre style="margin-top:0px;margin-bottom:0px"><span style="font-family:arial,sans-serif;color:rgb(192,192,192)"> </span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">rootInfo</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">.</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">setShowingDesktop</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">(</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">b</span><span style="font-family:arial,sans-serif;color:rgb(0,0,0)">);</span><br></pre>
<pre style="margin-top:0px;margin-bottom:0px"><span style="color:rgb(0,0,0)">}</span></pre><pre style="margin-top:0px;margin-bottom:0px"><span style="color:rgb(0,0,0)"><br></span></pre><pre style="margin-top:0px;margin-bottom:0px"><span style="color:rgb(0,0,0)">PS:</span><font color="#000000"><a href="https://git.reviewboard.kde.org/r/121667/">https://git.reviewboard.kde.org/r/121667/</a> fixed not only openbox, but also gnome-shell/mutter. Thanks! </font></pre></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-02-20 18:25 GMT+02:00 Kai Uwe Broulik <span dir="ltr"><<a href="mailto:kde@privat.broulik.de" target="_blank">kde@privat.broulik.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border:1px #c9c399 solid;border-radius:6px">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121856/" target="_blank">https://git.reviewboard.kde.org/r/121856/</a>
</td>
</tr>
</tbody></table>
<br>
</span><table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border:1px gray solid;border-radius:6px">
<tbody><tr>
<td>
<h1 style="margin:0;padding:0;font-size:10pt">This change has been marked as submitted.</h1>
</td>
</tr>
</tbody></table>
<br>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border:1px #888a85 solid;border-radius:6px">
<tbody><tr>
<td><span class="">
<div>Review request for kwin and Plasma.</div>
<div>By Kai Uwe Broulik.</div>
</span><p style="color:grey"><i>Updated Feb. 20, 2015, 4:25 p.m.</i></p><span class="">
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kdeclarative
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">This is a thin proxy around KWindowSystem exposing most of its methods to qml via KWindowSystem item in an org.kde.kwindowsystem import.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">It uses QWindow instead of WId parameters so you can just pass a qml Item, such as a Plasma Dialog as parameter for ease of use (and so you cannot mess with others windows without effort, also I don't know what "WId" would translate to anyway). It omits all those methods that return WId/QWindow as I don't know how expensive QWindow::fromWinId is or who takes ownership of it. We need to decide which methods make sense in this import.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Methods that have signals and don't take parameters are turned into full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the rest stays Q_INVOKABLE.</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">The properties work and change accordingly (compositing active signal doesn't seem to be emitted by KWindowSystem in the first place, at least Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works for Review 121807</p></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
</span><span class=""><ul style="margin-left:3em;padding-left:0">
<li>src/qmlcontrols/CMakeLists.txt <span style="color:grey">(39c39a5)</span></li>
<li>src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kwindowsystemplugin/qmldir <span style="color:grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121856/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</span></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br></div>