Review Request 122644: Make units more finegrained

Kai Uwe Broulik kde at privat.broulik.de
Fri Feb 20 11:29:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122644/
-----------------------------------------------------------

(Updated Feb. 20, 2015, 11:29 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Just found this patch floating around in my frameworks checkout.

It's always if (ratio < n) { return size * (ratio - 0.5) } but with < 3.0 it returned 3.0 nonetheless.


Diffs
-----

  src/declarativeimports/core/units.cpp 298bbb7 

Diff: https://git.reviewboard.kde.org/r/122644/diff/


Testing
-------

Didn't notice anything unusual


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150220/c133a7e0/attachment.html>


More information about the Plasma-devel mailing list