Review Request 122644: Make units more finegrained

Sebastian Kügler sebas at kde.org
Fri Feb 20 11:09:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122644/#review76329
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Feb. 20, 2015, 10:31 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122644/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 10:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Just found this patch floating around in my frameworks checkout.
> 
> It's always if (ratio < n) { return size * (ratio - 0.5) } but with < 3.0 it returned 3.0 nonetheless.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/units.cpp 298bbb7 
> 
> Diff: https://git.reviewboard.kde.org/r/122644/diff/
> 
> 
> Testing
> -------
> 
> Didn't notice anything unusual
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150220/f35a8019/attachment-0001.html>


More information about the Plasma-devel mailing list