Review Request 122609: Drop size check for round ToolButton

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122609/
-----------------------------------------------------------

(Updated Feb. 17, 2015, 10:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Bugs: 339303 and 340588
    http://bugs.kde.org/show_bug.cgi?id=339303
    http://bugs.kde.org/show_bug.cgi?id=340588


Repository: plasma-framework


Description
-------

It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway.


Diffs
-----

  src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da 

Diff: https://git.reviewboard.kde.org/r/122609/diff/


Testing
-------

Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150217/73d0a8ca/attachment.html>