Review Request 122609: Drop size check for round ToolButton

[Aleix Pol Gonzalez]

> On Feb. 17, 2015, 5:56 p.m., Aleix Pol Gonzalez wrote:
> > Maybe it should be documented somewhere then, no? That if there's no text you get a round button.
> 
> Kai Uwe Broulik wrote:
>     ...a non-flat(!) button without text but yeah it's pretty magic unexpected

Yes, a bit. Well if you can document it, great. +1 nevertheless.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122609/#review76192
-----------------------------------------------------------


On Feb. 17, 2015, 5:31 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122609/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 5:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 339303 and 340588
>     http://bugs.kde.org/show_bug.cgi?id=339303
>     http://bugs.kde.org/show_bug.cgi?id=340588
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> It causes binding loops causing all sorts of weird behavior, like the tool buttons not always having a background in Klipper. Also, we're not supposed to mess with button sizes anyway.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/ToolButtonStyle.qml 3d4b8da 
> 
> Diff: https://git.reviewboard.kde.org/r/122609/diff/
> 
> 
> Testing
> -------
> 
> Didn't spot any obvious regressions, Klipper now has proper tool buttons and notification popup still works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150217/55a96177/attachment-0001.html>