Review Request 122592: Align digital clock to full minutes

[Marco Martin]

> On Feb. 16, 2015, 3:53 p.m., Marco Martin wrote:
> > applets/digital-clock/package/contents/ui/main.qml, line 57
> > <https://git.reviewboard.kde.org/r/122592/diff/1/?file=349952#file349952line57>
> >
> >     perhaps should be noalignment when showing seconds? (however is very weird that it's not working when the interval is a secons?)
> 
> Kai Uwe Broulik wrote:
>     That it doesn't work with seconds is understandable since it aligns it to minutes always.
>     On the other hand it doesn't work when I change it at runtime since the datasource says "already connected to a relay of the same interval"

that could use a little change in datasource (libplasma side), making it distinguish not only by time interval but also alignment.
Or, it can just be made to disconnect then reconnect when changing alignment (qml binding side)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
-----------------------------------------------------------


On Feb. 16, 2015, 4:04 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
>     https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> -------
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150216/1d482230/attachment-0001.html>