Review Request 122592: Align digital clock to full minutes
Kai Uwe Broulik
kde at privat.broulik.de
Mon Feb 16 16:04:21 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
-----------------------------------------------------------
(Updated Feb. 16, 2015, 4:04 nachm.)
Review request for Plasma and Martin Klapetek.
Changes
-------
Don't align when seconds are shown
It doesn't catch it up at runtime though
Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872
Repository: plasma-workspace
Description
-------
This aligns the digital clock to full minutes so it's no longer off by up to 30 seconds, and it allows us to increase the polling interval to 60s.
Diffs (updated)
-----
applets/digital-clock/package/contents/ui/main.qml 4cc83e8
Diff: https://git.reviewboard.kde.org/r/122592/diff/
Testing
-------
Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
This patch would require us to bump the plasma-framework dependency to 5.8
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150216/dcdce172/attachment.html>
More information about the Plasma-devel
mailing list