Review Request 122533: Port accessibility kcm somewhat to xcb xkb

Frederik Gladhorn gladhorn at kde.org
Thu Feb 12 16:49:32 UTC 2015



> On Feb. 12, 2015, 6:53 a.m., Martin Gräßlin wrote:
> > kcms/access/kaccess.cpp, lines 379-385
> > <https://git.reviewboard.kde.org/r/122533/diff/3/?file=348415#file348415line379>
> >
> >     Is there no event type defined in xkb?

I looked and finally checked how Qt does it, if you can find one, I'd be happy to use it.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122533/#review75900
-----------------------------------------------------------


On Feb. 11, 2015, 9:25 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122533/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 9:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I don't really speak xcb, so I'd appreciate if someone could look over this for sanity's sake. The patch seems relatively straight forward to me though. I wonder how broken the old code was, it seems to have been rotting for a while.
> 
> 
> Diffs
> -----
> 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
> 
> Diff: https://git.reviewboard.kde.org/r/122533/diff/
> 
> 
> Testing
> -------
> 
> After this change sticky keys and some of the other features seem to work again.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150212/8a42b040/attachment.html>


More information about the Plasma-devel mailing list