Review Request 122533: Port accessibility kcm somewhat to xcb xkb

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122533/#review75900
-----------------------------------------------------------



kcms/access/kaccess.h
<https://git.reviewboard.kde.org/r/122533/#comment52383>

    we normally use camel case: <QAbstractNativeEventFilter> without any prefix



kcms/access/kaccess.cpp
<https://git.reviewboard.kde.org/r/122533/#comment52381>

    Is there no event type defined in xkb?



kcms/access/kaccess.cpp
<https://git.reviewboard.kde.org/r/122533/#comment52379>

    Please use the xcb enum values instead of the Xlib defines:
    *  XCB_XKB_EVENT_TYPE_STATE_NOTIFY
    *  XCB_XKB_EVENT_TYPE_BELL_NOTIFY
    *  XCB_XKB_EVENT_TYPE_CONTROLS_NOTIFY



kcms/access/kaccess.cpp
<https://git.reviewboard.kde.org/r/122533/#comment52380>

    we normally use reinterpret_cast instead of c-casts



kcms/access/kaccess.cpp
<https://git.reviewboard.kde.org/r/122533/#comment52382>

    here I would also suggest to switch to the enum values from xcb.


- Martin Gräßlin


On Feb. 11, 2015, 10:25 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122533/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 10:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I don't really speak xcb, so I'd appreciate if someone could look over this for sanity's sake. The patch seems relatively straight forward to me though. I wonder how broken the old code was, it seems to have been rotting for a while.
> 
> 
> Diffs
> -----
> 
>   kcms/access/kaccess.h e101de4 
>   kcms/access/kaccess.cpp 2419efb 
> 
> Diff: https://git.reviewboard.kde.org/r/122533/diff/
> 
> 
> Testing
> -------
> 
> After this change sticky keys and some of the other features seem to work again.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150212/e9ab375b/attachment.html>