Review Request 122500: Don't delete widgets directly when changing styles
Hugo Pereira Da Costa
hugo.pereira at free.fr
Tue Feb 10 13:40:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122500/#review75782
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Pereira Da Costa
On Feb. 10, 2015, 1:25 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122500/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 1:25 p.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Repository: breeze
>
>
> Description
> -------
>
> Don't delete widgets we don't own when changing styles
>
> registerWidget may take an existing widget as a parameter. If so, we
> don't want to delete it when our paletteHelper is deleted for example if
> we change style.
>
>
> Diffs
> -----
>
> kstyle/breezepalettehelper.cpp 31c32c3
>
> Diff: https://git.reviewboard.kde.org/r/122500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150210/afe32e18/attachment.html>
More information about the Plasma-devel
mailing list