Review Request 122500: Don't delete widgets directly when changing styles

David Edmundson david at davidedmundson.co.uk
Tue Feb 10 13:25:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122500/
-----------------------------------------------------------

(Updated Feb. 10, 2015, 1:25 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Summary (updated)
-----------------

Don't delete widgets directly when changing styles


Repository: breeze


Description
-------

Don't delete widgets we don't own when changing styles

registerWidget may take an existing widget as a parameter. If so, we
don't want to delete it when our paletteHelper is deleted for example if
we change style.


Diffs (updated)
-----

  kstyle/breezepalettehelper.cpp 31c32c3 

Diff: https://git.reviewboard.kde.org/r/122500/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150210/369fdaf6/attachment.html>


More information about the Plasma-devel mailing list