Review Request 122494: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122494/#review75687
-----------------------------------------------------------


Doesn't look like an improvement to me, especially the network management applet becomes more fiddly, it barely shows two available networks after patching, I'd much rather prevent having to scroll in there.

The bottom line is that with fixed spacing, some people will find it too large, others too small. With that in mind, the current size is a decent compromise. As long as it isn't clipped on a low-res screen such as the one you're using, I think that's fine, it can't ever be perfect, but showing less information there doesn't improve it, when opening this popup, the user actually wants to get at that information, forcing him/her to scroll in more cases is just going to make the user experience worse for everybody (not just the ones with low-res displays).

For the battery monitor, this patch looks like it would actually force a scrollbar there as well as soon as keyboard brightness controls come into place, or even inhibition notifications. We do really need the space that now looks empty there. For klipper, it's going to be more fiddly as well.

-2 from my side, sorry.

- Sebastian Kügler


On Feb. 8, 2015, 11:34 p.m., Blaga Florentin Gabriel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122494/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 11:34 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> KDE Plasma 5 system tray expanded applets resize for notebooks
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc 771837c982012f580f10923aa83d83b181afc881 
>   applets/systemtray/package/contents/ui/main.qml 553ad7a23d8d18974a02f35dc64b3f7dd4816585 
> 
> Diff: https://git.reviewboard.kde.org/r/122494/diff/
> 
> 
> Testing
> -------
> 
> Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the "before" and "after" the edit.
> 
> Kind regards!
> 
> 
> File Attachments
> ----------------
> 
> battery_unmod_laptop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05de2078-6dce-4578-a6a4-06bb6811e7e1__battery_unmod_laptop.png
> battery_modif_laptop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2c497b47-5180-420e-93bb-09a0225acd3b__battery_modif_laptop.png
> networks_unmodif_laptop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/4752ba6f-329b-461b-bab9-b3cf6c6707ae__networks_unmodif_laptop.png
> networks_modif_laptop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b614adf0-9d88-4c64-a448-07c9f5d39fd5__networks_modif_laptop.png
> high_unmodif_bat.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1600dac7-9516-4ec9-b66e-ce595c82d10a__high_unmodif_bat.png
> high_modif_bat.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/7f00e424-1c76-490a-a698-ec25e148101c__high_modif_bat.png
> wireless_unmodif_hires.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/71a32e89-ffdd-49c4-9db2-8a0e02b1c777__wireless_unmodif_hires.png
> wireless_modif_hires.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/469148e3-9ac6-4e0e-aafc-91431e87a48d__wireless_modif_hires.png
> 
> 
> Thanks,
> 
> Blaga Florentin Gabriel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150209/c49b1b92/attachment-0001.html>