<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122494/">https://git.reviewboard.kde.org/r/122494/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Doesn't look like an improvement to me, especially the network management applet becomes more fiddly, it barely shows two available networks after patching, I'd much rather prevent having to scroll in there.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The bottom line is that with fixed spacing, some people will find it too large, others too small. With that in mind, the current size is a decent compromise. As long as it isn't clipped on a low-res screen such as the one you're using, I think that's fine, it can't ever be perfect, but showing less information there doesn't improve it, when opening this popup, the user actually wants to get at that information, forcing him/her to scroll in more cases is just going to make the user experience worse for everybody (not just the ones with low-res displays).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For the battery monitor, this patch looks like it would actually force a scrollbar there as well as soon as keyboard brightness controls come into place, or even inhibition notifications. We do really need the space that now looks empty there. For klipper, it's going to be more fiddly as well.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-2 from my side, sorry.</p></pre>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 8th, 2015, 11:34 p.m. UTC, Blaga Florentin Gabriel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Blaga Florentin Gabriel.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2015, 11:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE Plasma 5 system tray expanded applets resize for notebooks</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hello I've modified the size of the expanded system tray applets using the file main.qml located at: /usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I have uploaded a copy of the modified file below), thus when expanded they take less space on notebook screens with low resolution (15 inch 1376x768), I also tested it with a high resolution monitor (19 inch) and it definitely improves the space there too. Below there are some screenshots with the "before" and "after" the edit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kind regards!</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(771837c982012f580f10923aa83d83b181afc881)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(553ad7a23d8d18974a02f35dc64b3f7dd4816585)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122494/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05de2078-6dce-4578-a6a4-06bb6811e7e1__battery_unmod_laptop.png">battery_unmod_laptop.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2c497b47-5180-420e-93bb-09a0225acd3b__battery_modif_laptop.png">battery_modif_laptop.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/4752ba6f-329b-461b-bab9-b3cf6c6707ae__networks_unmodif_laptop.png">networks_unmodif_laptop.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b614adf0-9d88-4c64-a448-07c9f5d39fd5__networks_modif_laptop.png">networks_modif_laptop.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1600dac7-9516-4ec9-b66e-ce595c82d10a__high_unmodif_bat.png">high_unmodif_bat.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/7f00e424-1c76-490a-a698-ec25e148101c__high_modif_bat.png">high_modif_bat.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/71a32e89-ffdd-49c4-9db2-8a0e02b1c777__wireless_unmodif_hires.png">wireless_unmodif_hires.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/469148e3-9ac6-4e0e-aafc-91431e87a48d__wireless_modif_hires.png">wireless_modif_hires.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>