Review Request 122463: Wipe source when IconItem becomes invisible

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122463/#review75553
-----------------------------------------------------------


It does seem to break the close icon in the notification popup :/

- Kai Uwe Broulik


On Feb. 7, 2015, 12:14 vorm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122463/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2015, 12:14 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> When IconItem becomes invisible release the image. This prevents transition from stale pixmaps, like in the tooltip, and could reduce memory consumption. 
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h d3b9305 
>   src/declarativeimports/core/iconitem.cpp 5da5265 
> 
> Diff: https://git.reviewboard.kde.org/r/122463/diff/
> 
> 
> Testing
> -------
> 
> I didn't notice a performance impact, when eg. opening the systray popup or kickoff.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150207/5a340e8c/attachment.html>