Review Request 122463: Wipe source when IconItem becomes invisible

Kai Uwe Broulik kde at privat.broulik.de
Sat Feb 7 00:14:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122463/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

When IconItem becomes invisible release the image. This prevents transition from stale pixmaps, like in the tooltip, and could reduce memory consumption. 


Diffs
-----

  src/declarativeimports/core/iconitem.h d3b9305 
  src/declarativeimports/core/iconitem.cpp 5da5265 

Diff: https://git.reviewboard.kde.org/r/122463/diff/


Testing
-------

I didn't notice a performance impact, when eg. opening the systray popup or kickoff.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150207/90dce3db/attachment-0001.html>


More information about the Plasma-devel mailing list