Review Request 122383: Remove internal copy of KXmlRpcClient

David Edmundson david at davidedmundson.co.uk
Mon Feb 2 18:21:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122383/#review75229
-----------------------------------------------------------


+1 as soon as it's a framework

- David Edmundson


On Feb. 2, 2015, 3:37 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122383/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 3:37 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Rohan Garg.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The internal copy isn't needed as soon as KXmlRpcClient becomes a framework.
> 
> 
> Diffs
> -----
> 
>   drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in 8f99a29 
>   drkonqi/internalkxmlrpcclient/README d8b6cd2 
>   drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt f737d14 
>   drkonqi/internalkxmlrpcclient/autotests/testclient.h e4897a3 
>   drkonqi/internalkxmlrpcclient/autotests/testclient.cpp f10b20a 
>   drkonqi/internalkxmlrpcclient/autotests/testquery.h 7957af6 
>   drkonqi/internalkxmlrpcclient/autotests/testquery.cpp f43a7ff 
>   drkonqi/internalkxmlrpcclient/src/CMakeLists.txt 884599e 
>   drkonqi/internalkxmlrpcclient/src/Messages.sh 059f34d 
>   drkonqi/internalkxmlrpcclient/src/client.h 60866da 
>   drkonqi/internalkxmlrpcclient/src/client.cpp 779a01a 
>   drkonqi/internalkxmlrpcclient/src/query.h cd6b786 
>   drkonqi/internalkxmlrpcclient/src/query.cpp ff18e24 
>   drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp 83d299a 
>   CMakeLists.txt e4d2b2d 
>   drkonqi/CMakeLists.txt d851d84 
>   drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 12d9626 
>   drkonqi/internalkxmlrpcclient/CMakeLists.txt 276aeaa 
>   drkonqi/internalkxmlrpcclient/COPYING.BSD cca2a5c 
> 
> Diff: https://git.reviewboard.kde.org/r/122383/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150202/4199b659/attachment.html>


More information about the Plasma-devel mailing list