<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122383/">https://git.reviewboard.kde.org/r/122383/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 as soon as it's a framework</p></pre>
 <br />









<p>- David Edmundson</p>


<br />
<p>On February 2nd, 2015, 3:37 p.m. UTC, Aleix Pol Gonzalez wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and Rohan Garg.</div>
<div>By Aleix Pol Gonzalez.</div>


<p style="color: grey;"><i>Updated Feb. 2, 2015, 3:37 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The internal copy isn't needed as soon as KXmlRpcClient becomes a framework.</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in <span style="color: grey">(8f99a29)</span></li>

 <li>drkonqi/internalkxmlrpcclient/README <span style="color: grey">(d8b6cd2)</span></li>

 <li>drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt <span style="color: grey">(f737d14)</span></li>

 <li>drkonqi/internalkxmlrpcclient/autotests/testclient.h <span style="color: grey">(e4897a3)</span></li>

 <li>drkonqi/internalkxmlrpcclient/autotests/testclient.cpp <span style="color: grey">(f10b20a)</span></li>

 <li>drkonqi/internalkxmlrpcclient/autotests/testquery.h <span style="color: grey">(7957af6)</span></li>

 <li>drkonqi/internalkxmlrpcclient/autotests/testquery.cpp <span style="color: grey">(f43a7ff)</span></li>

 <li>drkonqi/internalkxmlrpcclient/src/CMakeLists.txt <span style="color: grey">(884599e)</span></li>

 <li>drkonqi/internalkxmlrpcclient/src/Messages.sh <span style="color: grey">(059f34d)</span></li>

 <li>drkonqi/internalkxmlrpcclient/src/client.h <span style="color: grey">(60866da)</span></li>

 <li>drkonqi/internalkxmlrpcclient/src/client.cpp <span style="color: grey">(779a01a)</span></li>

 <li>drkonqi/internalkxmlrpcclient/src/query.h <span style="color: grey">(cd6b786)</span></li>

 <li>drkonqi/internalkxmlrpcclient/src/query.cpp <span style="color: grey">(ff18e24)</span></li>

 <li>drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp <span style="color: grey">(83d299a)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(e4d2b2d)</span></li>

 <li>drkonqi/CMakeLists.txt <span style="color: grey">(d851d84)</span></li>

 <li>drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp <span style="color: grey">(12d9626)</span></li>

 <li>drkonqi/internalkxmlrpcclient/CMakeLists.txt <span style="color: grey">(276aeaa)</span></li>

 <li>drkonqi/internalkxmlrpcclient/COPYING.BSD <span style="color: grey">(cca2a5c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122383/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>