Review Request 124047: Improve clock's tooltip layout

[Martin Klapetek]

> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote:
> > It still does not shrink if timezones are removed.
> > 
> > Otherwise looking good.
> 
> Martin Klapetek wrote:
>     Tips for the shrinking issue?

Ok found the issue; it was because I was setting a Loader
as the tooltipItem and the Loader was never resized.

New patch incoming.


> On Dec. 22, 2015, 10:53 p.m., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 637-643
> > <https://git.reviewboard.kde.org/r/124047/diff/5/?file=425397#file425397line637>
> >
> >     You should probably sort them also when I add new ones in the config UI.

Yeah, right.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review89950
-----------------------------------------------------------


On Dec. 22, 2015, 8:38 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 8:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
>     https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> -------
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151231/9722a57a/attachment-0001.html>