Review Request 124047: Improve clock's tooltip layout

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review89958
-----------------------------------------------------------



applets/digital-clock/package/contents/ui/Tooltip.qml (line 125)
<https://git.reviewboard.kde.org/r/124047/#comment61660>

    It's buggy because it would be an undetectable binding loop 
    
    your gridlayout uses it's implicitWidth (size of the children) in it's own size hinting. 
    layout.fillWidth would set the items to the size of the grid



applets/digital-clock/package/contents/ui/Tooltip.qml (line 131)
<https://git.reviewboard.kde.org/r/124047/#comment61661>

    this won't do anything.


- David Edmundson


On Dec. 22, 2015, 7:38 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 7:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
>     https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> -------
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151223/05843b48/attachment.html>